[PATCH resend 5/8] comctl32/tests: Test for LB_SETCOUNT without LBS_NODATA

Nikolay Sivov nsivov at codeweavers.com
Tue Nov 6 10:54:36 CST 2018


On 11/6/18 7:43 PM, Francois Gouget wrote:

> On Mon, 5 Nov 2018, Nikolay Sivov wrote:
> [...]
>> It's true that it's not a new failure, I've seen testbot report it many
>> times for sent patches. Don't know about full test results.
> I found why the test fails on wvistau64. From the description of the
> configuration for that VM:
>
>     Running tests from E: drive.
>
> The tests are run from E:\ which is an empty drive so it has no
> subfolders and no '..' parent directory. This is why LB_DIR fails when
> asked to only return directories.
>
> So comctl32:listbox requires to be run in a path with either a '..'
> parent directory or some subdirectory (despite stating the opposite in a
> comment). Such a requirement is wrong.
>
> And the reason it does not fail during the full test suite must be that
> some previous test leaves directories behind.
>
>
> So comctl32:listbox is broken.
> And some other test is broken too.

Makes sense. I'll send something to make it better.



>



More information about the wine-devel mailing list