color_match in dlls/d3d8/tests/visual.c may not do what one would think

Henri Verbeet hverbeet at gmail.com
Wed Nov 7 02:44:42 CST 2018


On Wed, 7 Nov 2018 at 03:40, Gerald Pfeifer <gerald at pfeifer.com> wrote:
> Thanks for looking into this and the explanation.  Since we are in
> unsigned land, the abs() really is a noop, so at a minimum should
> be removed?  I'll submit a patch in a minute.
>
No, there's a type conversion when passing the unsigned value to
abs(). I.e., abs(~0u) == 1.



More information about the wine-devel mailing list