[PATCH 10/14] rpcrt4: Write type format strings for Automation types.

[Alexandre Julliard]

Zebediah Figura <z.figura12 at gmail.com> writes:

> On 11/8/18 1:01 PM, Alexandre Julliard wrote:
>> Zebediah Figura <z.figura12 at gmail.com> writes:
>>
>>> On 11/05/2018 08:57 AM, Alexandre Julliard wrote:
>>>> A magic option is not great, but it would certainly be better than that
>>>> ugly command sequence ;-)
>>>
>>> Sure, understandable; I'll send a v2 of this patch using that approach.
>>>
>>> I'd like to find a cleaner method than either, but I'm hard-pressed to
>>> think of one. If anyone has any other ideas, please feel free to speak.
>>
>> I'd suggest something along these lines:
>>
>> *snip*
>>
>
> This is a good idea, and I wish I'd thought of it ;-)
>
> One possible concern I have is that widl isn't required to generate
> type format strings for individual parameters contiguously or in
> order. As things stand there's no reason for it not to, but that may
> not always be the case. For instance, MIDL is known to shorten the
> type format string by reusing entries for previously used types. I
> could see a widl implementation of this optimization being desirable,
> and possibly violating order constraints depending on how types are
> collapsed and written. Is this a salient concern?

If we add widl optimizations, we'll have to verify that the assumptions
still hold, and possibly use different types. Hopefully the tests will
catch any breakage.

-- 
Alexandre Julliard
julliard at winehq.org