[PATCH 2/2] hidclass.sys: Use IoSetDeviceInterfaceState

Zebediah Figura z.figura12 at gmail.com
Tue Nov 13 19:10:11 CST 2018


On 11/13/2018 06:34 PM, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric at codeweavers.com>
> ---
>   dlls/hidclass.sys/device.c | 18 ------------------
>   dlls/hidclass.sys/pnp.c    |  8 ++++++++
>   2 files changed, 8 insertions(+), 18 deletions(-)
> 
> 
> 
> 
> 

The title here seems similarly confusing, since hidclass already was 
using IoSetDeviceInterfaceState(); what you've rather done is to remove 
the call to IoCreateSymbolicLink() since ntoskrnl now takes care of 
that, and move the call to IoSetDeviceInterfaceState() into 
PNP_RemoveDevice() [which does seem more sensible than where it is now]. 
I'm inclined to think these should be separate patches, if indeed the 
first part won't have to be merged into the ntoskrnl patch to avoid a 
temporary breakage.



More information about the wine-devel mailing list