[PATCH 2/2] d3dx9: Add FIXME for unlockable source surface in D3DXLoadSurfaceFromSurface().

[Paul Gofman]

On 11/16/18 21:07, Matteo Bruni wrote:
> On Fri, Nov 16, 2018 at 5:38 PM Paul Gofman <gofmanp at gmail.com> wrote:
>> On 11/16/18 18:08, Matteo Bruni wrote:
>>
> I was thinking of just calling GetDesc() on the source surface and
> checking for D3DUSAGE_RENDERTARGET.
> I'm not sure that using StretchRect() / UpdateSurface() is that useful
> in practice, e.g. the default filter would disqualify both of them
> immediately.
      As I understand filter (unlike color key) is not supposed to do 
anything if surface is not resized and pixel format is the same, and I 
believe it is rather frequent use case. Apart from that default filter 
is not currently supported (ignored with FIXME) in d3dx9 anyway, so it 
could continue to be not supported using a quicker StretchRect() for a 
time being without any functionality loss, while this would probably be 
not a nice solution.
> Also StretchRect() has pretty weird / inconsistent
> restrictions on its use. That said, if you want to add a fast path for
> the cases that are supported by those I certainly won't oppose it :)
>
>>   
>> Sounds good. I'd probably wait for Henri's patches before venturing
>> too far along the plan.
>>
So if Henri is preparing something in this area I won't be touching it 
for now.