[PATCH v2] kernel32: Ignore FileIoPriorityHintInfo return success

Greg codedonewell at gmail.com
Sat Nov 17 01:47:53 CST 2018


On 17/11/18 3:46 pm, Zebediah Figura wrote:
> On 11/16/18 10:40 PM, Dmitry Timoshkov wrote:
>> Greg Smith <codedonewell at gmail.com> wrote:
>>
>>> +    case FileIoPriorityHintInfo:
>>> +        FIXME( "Ignoring file IO priority hint: %p, %u, %p, %u\n", 
>>> file, class, info, size );
>>> +        return TRUE;
>>
>> It would be helpful to add standard parameter checks.
>>
>
> It may also be helpful to forward it to ntdll and implement the stub 
> there, though perhaps this isn't worthwhile.
>
>
This patch is an alteration to SetFileInformationByHandle which already 
exists in kernel32/file.c (line 1089) and currently "pretty much" only 
supports FileDispositionInfo. Are you suggesting I should move the whole 
method to ntdll? Or just create a stub there for when 
SetFileInformationByHandle is called with this particular class 
parameter value?

Thanks for the feedback - this is my first patch, so I appreciate the 
guidance.



More information about the wine-devel mailing list