[PATCH] Revert "include: Use the ARRAY_SIZE() macro in debug.h."

Henri Verbeet hverbeet at gmail.com
Sun Nov 18 13:15:56 CST 2018


On Sun, 18 Nov 2018 at 21:19, Andre Heider <a.heider at gmail.com> wrote:
> Hm, are they private? They're installed, and using wine's debug channels
> work just fine. Looking at the file, there're specific macros for
> !__WINESRC__ too, e.g. WINE_FIXME().
>
I think that's largely historic, we didn't use to define __WINESRC__
for tests and programs.

> Apart from the debug channels, we use these too: toupperW() (unicode.h)
> wine_dlopen() (library.h), and I guess a few more.
>
Again, what are you doing exactly that you need those?

> Are the specific reasons to not expose those useful functions to
> external projects?
>
I'm sure we'd consider it if there was a demand for them. As it is
though, there's no guarantee those won't go away between releases, or
change in incompatible ways, etc. Depending on what you're using them
for, chances are that you should either be using the official Win32
APIs, or just be defining __WINESRC__. Perhaps you're doing something
unusual enough that neither of those is an option, but in that case
we'd be curious to learn more details.



More information about the wine-devel mailing list