[PATCH v2] winebus.sys: Allow XBOX Masquerade to be turned off

[Brendan McGrath]

I'm not a fan of the registry hack either - it should be plug and play.

To match Windows functionality would be to remove the masquerade (as 
Proton has). That would fix my problem - but potentially create an issue 
for other games that are dependant on this masquerade (although I'm not 
familiar with the reasons behind its inclusion).

Perhaps a compromise is to keep this registry hack but have it default 
to use the real VID and PID. Then it matches Windows but there is still 
an option for those who need the masquerade (and they can choose the 
device to which they masquerade).

On 20/11/18 12:17 pm, Zebediah Figura wrote:
>
> Be that as it may, I'm not sure that a registry hack is the approach 
> we want to take. If the game doesn't work with controllers that don't 
> report themselves as gamepads, but should, then we should fix it to work.
>
> At the same time, as regards your original problem, we should look to 
> rewrite the dinput joystick code on top of Wine's HID stack, so that 
> it will report the same VID/PID as xinput does. I believe Aric is 
> working on some patches to this effect ;-)
>
>