[PATCH v2 1/3] ole32: Add NULL pointer checks to PropVariantCopy.

Sven Baars sven.wine at gmail.com
Tue Nov 20 03:17:42 CST 2018


On Tue, Nov 20, 2018 at 9:55 AM Huw Davies <huw at codeweavers.com> wrote:

> On Sat, Nov 17, 2018 at 10:03:09PM +0100, Sven Baars wrote:
> > Signed-off-by: Sven Baars <sven.wine at gmail.com>
> > ---
> >
> > v2: Added NULL checks to PropVariantCopy instead.
> >
> >  dlls/ole32/ole2.c              |  3 +++
> >  dlls/ole32/tests/propvariant.c | 14 ++++++++++++++
> >  2 files changed, 17 insertions(+)
>
> Do you have an app that depends on this behaviour?
>
> Huw.
>

Hi Huw,

No, but Nikolay asked me to implement this here instead of in mfplat. For
that I had an app that depended on it for a few days or so, which was
obviously a bug since they tried to put something into a NULL pointer, so
they fixed that already. I thought I should submit the patch anyway since
it matches Windows behaviour.

Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20181120/ab6f1d7c/attachment.html>


More information about the wine-devel mailing list