[PATCH v2 1/3] ole32: Add NULL pointer checks to PropVariantCopy.

[Sven Baars]

On Tue, Nov 20, 2018 at 10:26 AM Huw Davies <huw at codeweavers.com> wrote:
>
> On Tue, Nov 20, 2018 at 10:17:42AM +0100, Sven Baars wrote:
> > On Tue, Nov 20, 2018 at 9:55 AM Huw Davies <huw at codeweavers.com> wrote:
> >      On Sat, Nov 17, 2018 at 10:03:09PM +0100, Sven Baars wrote:
> >      > Signed-off-by: Sven Baars <sven.wine at gmail.com>
> >      > ---
> >      >
> >      > v2: Added NULL checks to PropVariantCopy instead.
> >      >
> >      >  dlls/ole32/ole2.c              |  3 +++
> >      >  dlls/ole32/tests/propvariant.c | 14 ++++++++++++++
> >      >  2 files changed, 17 insertions(+)
> >
> >      Do you have an app that depends on this behaviour?
> >
> >      Huw.
> >
> > Hi Huw,
> >
> > No, but Nikolay asked me to implement this here instead of in mfplat. For that
> > I had an app that depended on it for a few days or so, which was obviously a
> > bug since they tried to put something into a NULL pointer, so they fixed that
> > already. I thought I should submit the patch anyway since it matches Windows
> > behaviour.
>
> If the app doesn't require it any longer then let's leave this out.  We tend
> to avoid adding NULL-ptr checks unless we need to.
>
> Huw.

Ok, I'll keep that in mind for future patches.

Sven