[PATCH 2/2] comctl32/listbox: Implement LBS_NODATA

Gabriel Ivăncescu gabrielopcode at gmail.com
Tue Nov 20 04:51:34 CST 2018


On Tue, Nov 20, 2018 at 12:48 PM Huw Davies <huw at codeweavers.com> wrote:
>
> It seems to me that LISTBOX_SetCount() is likely to be a performance
> bottleneck.  Of course one would have to do profiling to check that,
> but it seems likely.  This could easily be optimized by allocating
> the items in one go.
>
> Huw.

Last time I did this, the patch was rejected because "it wasn't
LBS_NODATA behavior so let's postpone it until we implement it" or
something to that effect. Well now I'm trying to implement it
properly...

Keep in mind that the memory usage will be massive compared to
Windows, even if we allocate it in one go, so it's mostly a temporary
band-aid, if anything, and it will still depend on the number of items
count (albeit, much faster), which it shouldn't.



More information about the wine-devel mailing list