[PATCH v3 6/7] comctl32/listbox: Implement LBS_NODATA for single-selection listboxes

Gabriel Ivăncescu gabrielopcode at gmail.com
Wed Nov 21 13:23:10 CST 2018


On Wed, Nov 21, 2018 at 8:07 PM Huw Davies <huw at codeweavers.com> wrote:
> It will always multiply by something, that number might be sizeof(BYTE).
> The function will decide what to multiply by based on descr->style.  This
> really isn't that complicated...
>
> Huw.

Sorry, gmail bugged out on me without updating, and I saw your reply
only after sending patches in (they use the previous approach but
split from the patch). I didn't mean to sound like I ignored this
approach, I'll see what I can do tomorrow about it if you still
dislike this way.

That said, the allocators for SetCount also need to zero out (rounded,
for future) memory so I think it's still plausible to have them
separated and avoid style checks.

Also, using one common allocator will also complicate it if we ever
change to a bit array, since we can't multiply by 1/8.

Anyway like I said I will resend tomorrow if you don't change your
mind about it, since i just saw your reply and I already sent them :-/



More information about the wine-devel mailing list