[PATCH 2/2] msi: Remove use of SystemDir when loading mscoree

[Hans Leidekker]

On Mon, 2018-11-26 at 20:23 +1100, Brendan McGrath wrote:
> The current behaviour causes a crash during install of dotnet35
> on a 64-bit prefix. This is because the 32-bit install looks for
> mscoree.dll in the 'System32' dir which is a 64-bit binary thus
> no valid mscoree.dll can be loaded.
> 
> The crash actually occurs within get_clr_version as pGetFileVersion
> ends up with a value that is neither NULL or valid (fixed in patch 1
> of this series).
> 
> This patch allows the syswow64 version of mscoree.dll to be
> found and used.
> 
> Signed-off-by: Brendan McGrath <brendan at redmandi.com>
> ---
> 
> With this patch no crash occurs during a dotnet35 install. However,
> I'm not sure if this is the correct approach as the use of 'System32'
> seems quite intentional.

It is. We shouldn't load mscoree from the current directory. Is there a
bug report for this issue?