[PATCH] testbot/web: Remove OnPrev() and OnNext() from Submit.

Francois Gouget fgouget at codeweavers.com
Mon Nov 26 21:04:32 CST 2018


These one-liners add an unnecessary layer of indirection.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/web/Submit.pl | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 85a12a0f09..67c1f9b600 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -709,13 +709,6 @@ sub OnPage2Next($)
   return 1;
 }
 
-sub OnNext($)
-{
-  my ($self) = @_;
-
-  return $self->{Page} == 2 ? $self->OnPage2Next() : $self->OnPage1Next();
-}
-
 sub OnPage2Prev($)
 {
   my ($self) = @_;
@@ -741,12 +734,6 @@ sub OnPage3Prev($)
   return 1;
 }
 
-sub OnPrev($)
-{
-  my ($self) = @_;
-
-  return $self->{Page} == 3 ? $self->OnPage3Prev() : $self->OnPage2Prev();
-}
 
 sub SubmitJob($$$)
 {
@@ -1018,11 +1005,11 @@ sub OnAction($$)
 
   if ($Action eq "Next >")
   {
-    return $self->OnNext();
+    return $self->{Page} == 2 ? $self->OnPage2Next() : $self->OnPage1Next();
   }
   elsif ($Action eq "< Prev")
   {
-    return $self->OnPrev();
+    return $self->{Page} == 3 ? $self->OnPage3Prev() : $self->OnPage2Prev();
   }
   elsif ($Action eq "Submit")
   {
-- 
2.19.1




More information about the wine-devel mailing list