[PATCH 1/2] kernel32/tests: Align SizeOfHeaders to FileAlignment

Alexandre Julliard julliard at winehq.org
Thu Nov 29 03:33:38 CST 2018


Brendan McGrath <brendan at redmandi.com> writes:

> According to:
> https://docs.microsoft.com/en-us/windows/desktop/debug/pe-format#optional-header-windows-specific-fields-image-only
>
> SizeOfHeaders: The combined size of an MS-DOS stub, PE header, and section headers rounded up to a multiple of FileAlignment.
>
> This change also fixes two kernel loader tests currently failing under 64bit.
>
> Signed-off-by: Brendan McGrath <brendan at redmandi.com>
> ---
> This patch set fixes three of the four failing 64bit kernel32 loader tests.
>
> The remaining test that fails is due to the clr header being version 2.4 and wine only offering
> 64bit support for clr header version 2.5 and above. I couldn't find any documentation
> to state why that is so I've left the test as failing.

These tests succeed on Windows. You should be fixing the Wine
implementation to pass the tests, not the other way around.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list