[v2 PATCH 4/5] wincodecs: Trace stream methods arguments.

Nikolay Sivov nsivov at codeweavers.com
Thu Nov 29 03:36:44 CST 2018


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/windowscodecs/stream.c | 106 ++++++++++++++++++++----------------
 1 file changed, 60 insertions(+), 46 deletions(-)

diff --git a/dlls/windowscodecs/stream.c b/dlls/windowscodecs/stream.c
index 308ef8e02b..ae90dfd379 100644
--- a/dlls/windowscodecs/stream.c
+++ b/dlls/windowscodecs/stream.c
@@ -101,7 +101,8 @@ static HRESULT WINAPI StreamOnMemory_Read(IStream *iface,
 {
     StreamOnMemory *This = StreamOnMemory_from_IStream(iface);
     ULONG uBytesRead;
-    TRACE("(%p)\n", This);
+
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbRead);
 
     if (!pv) return E_INVALIDARG;
 
@@ -121,7 +122,8 @@ static HRESULT WINAPI StreamOnMemory_Write(IStream *iface,
 {
     StreamOnMemory *This = StreamOnMemory_from_IStream(iface);
     HRESULT hr;
-    TRACE("(%p)\n", This);
+
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbWritten);
 
     if (!pv) return E_INVALIDARG;
 
@@ -146,7 +148,8 @@ static HRESULT WINAPI StreamOnMemory_Seek(IStream *iface,
     StreamOnMemory *This = StreamOnMemory_from_IStream(iface);
     LARGE_INTEGER NewPosition;
     HRESULT hr=S_OK;
-    TRACE("(%p)\n", This);
+
+    TRACE("(%p, %s, %d, %p)\n", This, wine_dbgstr_longlong(dlibMove.QuadPart), dwOrigin, plibNewPosition);
 
     EnterCriticalSection(&This->lock);
     if (dwOrigin == STREAM_SEEK_SET) NewPosition.QuadPart = dlibMove.QuadPart;
@@ -174,7 +177,7 @@ static HRESULT WINAPI StreamOnMemory_Seek(IStream *iface,
 static HRESULT WINAPI StreamOnMemory_SetSize(IStream *iface,
     ULARGE_INTEGER libNewSize)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s)\n", iface, wine_dbgstr_longlong(libNewSize.QuadPart));
     return E_NOTIMPL;
 }
 
@@ -182,7 +185,7 @@ static HRESULT WINAPI StreamOnMemory_SetSize(IStream *iface,
 static HRESULT WINAPI StreamOnMemory_CopyTo(IStream *iface,
     IStream *pstm, ULARGE_INTEGER cb, ULARGE_INTEGER *pcbRead, ULARGE_INTEGER *pcbWritten)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p, %s, %p, %p)\n", iface, pstm, wine_dbgstr_longlong(cb.QuadPart), pcbRead, pcbWritten);
     return E_NOTIMPL;
 }
 
@@ -190,7 +193,7 @@ static HRESULT WINAPI StreamOnMemory_CopyTo(IStream *iface,
 static HRESULT WINAPI StreamOnMemory_Commit(IStream *iface,
     DWORD grfCommitFlags)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %#x)\n", iface, grfCommitFlags);
     return E_NOTIMPL;
 }
 
@@ -205,7 +208,8 @@ static HRESULT WINAPI StreamOnMemory_Revert(IStream *iface)
 static HRESULT WINAPI StreamOnMemory_LockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
@@ -213,7 +217,8 @@ static HRESULT WINAPI StreamOnMemory_LockRegion(IStream *iface,
 static HRESULT WINAPI StreamOnMemory_UnlockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
@@ -221,7 +226,7 @@ static HRESULT WINAPI StreamOnMemory_Stat(IStream *iface,
     STATSTG *pstatstg, DWORD grfStatFlag)
 {
     StreamOnMemory *This = StreamOnMemory_from_IStream(iface);
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %p, %#x)\n", This, pstatstg, grfStatFlag);
 
     if (!pstatstg) return E_INVALIDARG;
 
@@ -236,7 +241,7 @@ static HRESULT WINAPI StreamOnMemory_Stat(IStream *iface,
 static HRESULT WINAPI StreamOnMemory_Clone(IStream *iface,
     IStream **ppstm)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p)\n", iface, ppstm);
     return E_NOTIMPL;
 }
 
@@ -331,7 +336,7 @@ static HRESULT WINAPI StreamOnFileHandle_Read(IStream *iface,
     void *pv, ULONG cb, ULONG *pcbRead)
 {
     StreamOnFileHandle *This = StreamOnFileHandle_from_IStream(iface);
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbRead);
 
     return IWICStream_Read(This->stream, pv, cb, pcbRead);
 }
@@ -339,7 +344,7 @@ static HRESULT WINAPI StreamOnFileHandle_Read(IStream *iface,
 static HRESULT WINAPI StreamOnFileHandle_Write(IStream *iface,
     void const *pv, ULONG cb, ULONG *pcbWritten)
 {
-    ERR("(%p)\n", iface);
+    ERR("(%p, %p, %u, %p)\n", iface, pv, cb, pcbWritten);
     return HRESULT_FROM_WIN32(ERROR_ACCESS_DENIED);
 }
 
@@ -347,7 +352,7 @@ static HRESULT WINAPI StreamOnFileHandle_Seek(IStream *iface,
     LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition)
 {
     StreamOnFileHandle *This = StreamOnFileHandle_from_IStream(iface);
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %s, %d, %p)\n", This, wine_dbgstr_longlong(dlibMove.QuadPart), dwOrigin, plibNewPosition);
 
     return IWICStream_Seek(This->stream, dlibMove, dwOrigin, plibNewPosition);
 }
@@ -355,21 +360,21 @@ static HRESULT WINAPI StreamOnFileHandle_Seek(IStream *iface,
 static HRESULT WINAPI StreamOnFileHandle_SetSize(IStream *iface,
     ULARGE_INTEGER libNewSize)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s)\n", iface, wine_dbgstr_longlong(libNewSize.QuadPart));
     return E_NOTIMPL;
 }
 
 static HRESULT WINAPI StreamOnFileHandle_CopyTo(IStream *iface,
     IStream *pstm, ULARGE_INTEGER cb, ULARGE_INTEGER *pcbRead, ULARGE_INTEGER *pcbWritten)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p, %s, %p, %p)\n", iface, pstm, wine_dbgstr_longlong(cb.QuadPart), pcbRead, pcbWritten);
     return E_NOTIMPL;
 }
 
 static HRESULT WINAPI StreamOnFileHandle_Commit(IStream *iface,
     DWORD grfCommitFlags)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %#x)\n", iface, grfCommitFlags);
     return E_NOTIMPL;
 }
 
@@ -382,14 +387,16 @@ static HRESULT WINAPI StreamOnFileHandle_Revert(IStream *iface)
 static HRESULT WINAPI StreamOnFileHandle_LockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
 static HRESULT WINAPI StreamOnFileHandle_UnlockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
@@ -397,7 +404,7 @@ static HRESULT WINAPI StreamOnFileHandle_Stat(IStream *iface,
     STATSTG *pstatstg, DWORD grfStatFlag)
 {
     StreamOnFileHandle *This = StreamOnFileHandle_from_IStream(iface);
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %p, %#x)\n", This, pstatstg, grfStatFlag);
 
     return IWICStream_Stat(This->stream, pstatstg, grfStatFlag);
 }
@@ -405,11 +412,10 @@ static HRESULT WINAPI StreamOnFileHandle_Stat(IStream *iface,
 static HRESULT WINAPI StreamOnFileHandle_Clone(IStream *iface,
     IStream **ppstm)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p)\n", iface, ppstm);
     return E_NOTIMPL;
 }
 
-
 static const IStreamVtbl StreamOnFileHandle_Vtbl =
 {
     /*** IUnknown methods ***/
@@ -509,7 +515,8 @@ static HRESULT WINAPI StreamOnStreamRange_Read(IStream *iface,
     HRESULT hr;
     ULARGE_INTEGER OldPosition;
     LARGE_INTEGER SetPosition;
-    TRACE("(%p)\n", This);
+
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbRead);
 
     if (!pv) return E_INVALIDARG;
 
@@ -552,7 +559,7 @@ static HRESULT WINAPI StreamOnStreamRange_Write(IStream *iface,
     ULARGE_INTEGER OldPosition;
     LARGE_INTEGER SetPosition;
     ULONG uBytesWritten=0;
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbWritten);
 
     if (!pv) return E_INVALIDARG;
 
@@ -594,7 +601,7 @@ static HRESULT WINAPI StreamOnStreamRange_Seek(IStream *iface,
     ULARGE_INTEGER NewPosition, actual_size;
     HRESULT hr=S_OK;
     STATSTG statstg;
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %s, %d, %p)\n", This, wine_dbgstr_longlong(dlibMove.QuadPart), dwOrigin, plibNewPosition);
 
     EnterCriticalSection(&This->lock);
     actual_size = This->max_size;
@@ -631,7 +638,7 @@ static HRESULT WINAPI StreamOnStreamRange_Seek(IStream *iface,
 static HRESULT WINAPI StreamOnStreamRange_SetSize(IStream *iface,
     ULARGE_INTEGER libNewSize)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s)\n", iface, wine_dbgstr_longlong(libNewSize.QuadPart));
     return E_NOTIMPL;
 }
 
@@ -639,7 +646,8 @@ static HRESULT WINAPI StreamOnStreamRange_SetSize(IStream *iface,
 static HRESULT WINAPI StreamOnStreamRange_CopyTo(IStream *iface,
     IStream *pstm, ULARGE_INTEGER cb, ULARGE_INTEGER *pcbRead, ULARGE_INTEGER *pcbWritten)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p, %s, %p, %p)\n", iface, pstm, wine_dbgstr_longlong(cb.QuadPart),
+        pcbRead, pcbWritten);
     return E_NOTIMPL;
 }
 
@@ -647,7 +655,7 @@ static HRESULT WINAPI StreamOnStreamRange_CopyTo(IStream *iface,
 static HRESULT WINAPI StreamOnStreamRange_Commit(IStream *iface,
     DWORD grfCommitFlags)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %#x)\n", iface, grfCommitFlags);
     return E_NOTIMPL;
 }
 
@@ -662,7 +670,8 @@ static HRESULT WINAPI StreamOnStreamRange_Revert(IStream *iface)
 static HRESULT WINAPI StreamOnStreamRange_LockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
@@ -670,7 +679,8 @@ static HRESULT WINAPI StreamOnStreamRange_LockRegion(IStream *iface,
 static HRESULT WINAPI StreamOnStreamRange_UnlockRegion(IStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %s, %s, %d)\n", iface, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
     return E_NOTIMPL;
 }
 
@@ -679,7 +689,7 @@ static HRESULT WINAPI StreamOnStreamRange_Stat(IStream *iface,
 {
     StreamOnStreamRange *This = StreamOnStreamRange_from_IStream(iface);
     HRESULT hr;
-    TRACE("(%p)\n", This);
+    TRACE("(%p, %p, %#x)\n", This, pstatstg, grfStatFlag);
 
     if (!pstatstg) return E_INVALIDARG;
 
@@ -701,11 +711,10 @@ static HRESULT WINAPI StreamOnStreamRange_Stat(IStream *iface,
 static HRESULT WINAPI StreamOnStreamRange_Clone(IStream *iface,
     IStream **ppstm)
 {
-    TRACE("(%p)\n", iface);
+    TRACE("(%p, %p)\n", iface, ppstm);
     return E_NOTIMPL;
 }
 
-
 static const IStreamVtbl StreamOnStreamRange_Vtbl =
 {
     /*** IUnknown methods ***/
@@ -795,7 +804,7 @@ static HRESULT WINAPI IWICStreamImpl_Read(IWICStream *iface,
     void *pv, ULONG cb, ULONG *pcbRead)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbRead);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Read(This->pStream, pv, cb, pcbRead);
@@ -805,7 +814,7 @@ static HRESULT WINAPI IWICStreamImpl_Write(IWICStream *iface,
     void const *pv, ULONG cb, ULONG *pcbWritten)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %p, %u, %p)\n", This, pv, cb, pcbWritten);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Write(This->pStream, pv, cb, pcbWritten);
@@ -815,7 +824,8 @@ static HRESULT WINAPI IWICStreamImpl_Seek(IWICStream *iface,
     LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %s, %d, %p)\n", This, wine_dbgstr_longlong(dlibMove.QuadPart),
+        dwOrigin, plibNewPosition);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Seek(This->pStream, dlibMove, dwOrigin, plibNewPosition);
@@ -825,7 +835,7 @@ static HRESULT WINAPI IWICStreamImpl_SetSize(IWICStream *iface,
     ULARGE_INTEGER libNewSize)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %s)\n", This, wine_dbgstr_longlong(libNewSize.QuadPart));
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_SetSize(This->pStream, libNewSize);
@@ -835,7 +845,7 @@ static HRESULT WINAPI IWICStreamImpl_CopyTo(IWICStream *iface,
     IStream *pstm, ULARGE_INTEGER cb, ULARGE_INTEGER *pcbRead, ULARGE_INTEGER *pcbWritten)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %p, %s, %p, %p)\n", This, pstm, wine_dbgstr_longlong(cb.QuadPart), pcbRead, pcbWritten);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_CopyTo(This->pStream, pstm, cb, pcbRead, pcbWritten);
@@ -845,7 +855,7 @@ static HRESULT WINAPI IWICStreamImpl_Commit(IWICStream *iface,
     DWORD grfCommitFlags)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %#x)\n", This, grfCommitFlags);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Commit(This->pStream, grfCommitFlags);
@@ -854,7 +864,7 @@ static HRESULT WINAPI IWICStreamImpl_Commit(IWICStream *iface,
 static HRESULT WINAPI IWICStreamImpl_Revert(IWICStream *iface)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p)\n", This);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Revert(This->pStream);
@@ -864,7 +874,8 @@ static HRESULT WINAPI IWICStreamImpl_LockRegion(IWICStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %s, %s, %d)\n", This, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_LockRegion(This->pStream, libOffset, cb, dwLockType);
@@ -874,7 +885,8 @@ static HRESULT WINAPI IWICStreamImpl_UnlockRegion(IWICStream *iface,
     ULARGE_INTEGER libOffset, ULARGE_INTEGER cb, DWORD dwLockType)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %s, %s, %d)\n", This, wine_dbgstr_longlong(libOffset.QuadPart),
+        wine_dbgstr_longlong(cb.QuadPart), dwLockType);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_UnlockRegion(This->pStream, libOffset, cb, dwLockType);
@@ -884,7 +896,7 @@ static HRESULT WINAPI IWICStreamImpl_Stat(IWICStream *iface,
     STATSTG *pstatstg, DWORD grfStatFlag)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %p, %#x)\n", This, pstatstg, grfStatFlag);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Stat(This->pStream, pstatstg, grfStatFlag);
@@ -894,7 +906,7 @@ static HRESULT WINAPI IWICStreamImpl_Clone(IWICStream *iface,
     IStream **ppstm)
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
-    TRACE("(%p): relay\n", This);
+    TRACE("(%p, %p)\n", This, ppstm);
 
     if (!This->pStream) return WINCODEC_ERR_NOTINITIALIZED;
     return IStream_Clone(This->pStream, ppstm);
@@ -904,7 +916,7 @@ static HRESULT WINAPI IWICStreamImpl_InitializeFromIStream(IWICStream *iface,
     IStream *pIStream)
 {
     ULARGE_INTEGER offset, size;
-    TRACE("(%p): relay\n", iface);
+    TRACE("(%p, %p)\n", iface, pIStream);
 
     offset.QuadPart = 0;
     size.u.LowPart = 0xffffffff;
@@ -967,7 +979,7 @@ static HRESULT WINAPI IWICStreamImpl_InitializeFromMemory(IWICStream *iface,
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
     StreamOnMemory *pObject;
-    TRACE("(%p,%p)\n", iface, pbBuffer);
+    TRACE("(%p, %p, %u)\n", iface, pbBuffer, cbBufferSize);
 
     if (!pbBuffer) return E_INVALIDARG;
     if (This->pStream) return WINCODEC_ERR_WRONGSTATE;
@@ -1068,7 +1080,9 @@ static HRESULT WINAPI IWICStreamImpl_InitializeFromIStreamRegion(IWICStream *ifa
 {
     IWICStreamImpl *This = impl_from_IWICStream(iface);
     StreamOnStreamRange *pObject;
-    TRACE("(%p,%p)\n", iface, pIStream);
+
+    TRACE("(%p,%p,%s,%s)\n", iface, pIStream, wine_dbgstr_longlong(ulOffset.QuadPart),
+        wine_dbgstr_longlong(ulMaxSize.QuadPart));
 
     if (!pIStream) return E_INVALIDARG;
     if (This->pStream) return WINCODEC_ERR_WRONGSTATE;
-- 
2.19.2




More information about the wine-devel mailing list