[PATCH 2/2] shell32/iconcache: Break as soon as one shortcut failed to overlay

[Gabriel Ivăncescu]

On Thu, Nov 29, 2018 at 1:37 PM Huw Davies <huw at codeweavers.com> wrote:
>
> Err, what this patch does is to optimize things when
> SIC_OverlayShortcutImage() fails (and unnecessarily move around a
> variable definition).  So the real problem would be why that function
> fails.
>
> FWIW the other patch was a bit of a hack, but having the imagelists go
> out of sync seemed worse than a missing icon, so I signed off on that
> one.
>
> Huw.

Oh sorry I thought you were speaking of the original (old) patchset
where I re-created missing icons from the available ones, which was
way more hackish :) My bad.

BTW I moved the variable definition, because I like/think it's better
to have them as localized as possible which is better for scope
encapsulation, it's just a coding style I follow (mostly from C++
projects). So I'm asking for future now if I should do this kind of
thing or it's not welcome in Wine policy unless I actually change more
of something or refactor a function?