[v3 PATCH 1/4] shcore: Implement a bunch of string conversion functions.

Alexandre Julliard julliard at winehq.org
Thu Nov 29 08:53:10 CST 2018


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>> > if (!src)
>> > {
>> >      *dst = 0;
>> >      return 1;
>> > }
>> >
>> > if (!WideCharToMultiByte(CP_ACP, 0, src, -1, dest, dest_len, NULL, NULL))
>> >      dest[dest_len - 1] = 0;
>> > return dest_len;
>> 
>> This does the same thing.
>
> That's the whole point: do the same thing using simpler code.

It doesn't do the same thing, the return value is wrong.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list