[v3 PATCH 1/4] shcore: Implement a bunch of string conversion functions.

[Dmitry Timoshkov]

Alexandre Julliard <julliard at winehq.org> wrote:

> >> > if (!src)
> >> > {
> >> >      *dst = 0;
> >> >      return 1;
> >> > }
> >> >
> >> > if (!WideCharToMultiByte(CP_ACP, 0, src, -1, dest, dest_len, NULL, NULL))
> >> >      dest[dest_len - 1] = 0;
> >> > return dest_len;
> >> 
> >> This does the same thing.
> >
> > That's the whole point: do the same thing using simpler code.
> 
> It doesn't do the same thing, the return value is wrong.

You are right of course, thanks.

-- 
Dmitry.