[PATCH v3 1/2] user32: Let nulldrv return some dummy monitor information.

Jacek Caban jacek at codeweavers.com
Tue Oct 2 09:12:33 CDT 2018


On 10/02/2018 03:45 PM, Bernhard Übelacker wrote:
> Hello Jacek,
> thanks for reviewing.
>
>>> +    if (handle != NULLDRV_DEFAULT_HMONITOR)
>>> +        return FALSE;
>> This should probably set last error to ERROR_INVALID_HANDLE (at least
>> that's what other drivers do).
> While the other drivers set ERROR_INVALID_HANDLE,
> in a non-interactive session I receive ERROR_INVALID_MONITOR_HANDLE on
> testbot [1].
>
> So I assume I should go ahead with the second?
>
> Kind regards,
> Bernhard
>
> [1] https://testbot.winehq.org/JobDetails.pl?Key=42787


Yes, ERROR_INVALID_MONITOR_HANDLE would be better then.


Jacek




More information about the wine-devel mailing list