[PATCH v4 2/2] services/tests: Retrieve monitor information when executed as service.

[Bernhard Übelacker]

Am 02.10.2018 um 16:33 schrieb Marvin:
> Hi,
> 
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=42789
> 
> Your paranoid android.
> 
> 
> === wvistau64_he (32 bit Windows report) ===
> 
> services.exe:
> service.c:431: Test failed: malformed service message: 1
> 

Could this just be caused by the pipe connecting the service with the
test process being opened with pipe type byte?
And due to more tests and/or longer lines the call to ReadLine takes now
not the whole line anymore?

I tried to stress the pipe by sending more data and it led to quite a
lot of failures [1], if the pipe is created with
PIPE_TYPE_BYTE|PIPE_READMODE_BYTE.

The same stress test with a pipe created with
PIPE_TYPE_MESSAGE|PIPE_READMODE_MESSAGE shows no failures [2].

[1] https://testbot.winehq.org/JobDetails.pl?Key=42797
[2] https://testbot.winehq.org/JobDetails.pl?Key=42798

If my opinion is considered right, should I just add to that patch
series at first a change of the pipe type from byte to message?

Kind regards,
Bernhard