[PATCH] server: copy_context(): Copy only valid information from source context.

Alexandre Julliard julliard at winehq.org
Thu Oct 4 15:45:52 CDT 2018


Joachim Priesner <joachim.priesner at web.de> writes:

> A thread's context may be incomplete. For example, the i386
> RtlCaptureContext() function does not save floating-point registers,
> setting the context's flags accordingly.
>
> Signed-off-by: Joachim Priesner <joachim.priesner at web.de>
> ---
> I'd like some feedback on whether this patch goes in the right
> direction. In particular, it breaks the functionality introduced in
> 03d31ea8 ("Only update the modified parts of the context on thread
> suspend") because the flags field is now used both to state what part of
> the context is valid and what part has changed.

I think it's the right direction, it shouldn't be hard to use a separate
field to store which flags have been changed instead of abusing the
context flags.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list