[PATCH 3/7] widl: Remove dead code.

Zebediah Figura z.figura12 at gmail.com
Fri Oct 5 16:57:48 CDT 2018


MIDL doesn't warn on this, and it's not a particularly salient mistake to make.

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
 tools/widl/parser.y | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/tools/widl/parser.y b/tools/widl/parser.y
index 3b99d93..1fe7129 100644
--- a/tools/widl/parser.y
+++ b/tools/widl/parser.y
@@ -1552,18 +1552,6 @@ static var_t *declare_var(attr_list_t *attrs, decl_spec_t *decl_spec, const decl
   ptype = &v->type;
   if (arr) LIST_FOR_EACH_ENTRY_REV(dim, arr, expr_t, entry)
   {
-    if (dim->is_const)
-    {
-      /* FIXME: should use a type_memsize that allows us to pass in a pointer size */
-      if (0)
-      {
-        unsigned int size = type_memsize(v->type);
-
-        if (0xffffffffu / size < dim->cval)
-          error_loc("%s: total array size is too large\n", v->name);
-      }
-    }
-
     *ptype = type_new_array(NULL, *ptype, FALSE,
                             dim->is_const ? dim->cval : 0,
                             dim->is_const ? NULL : dim, NULL,
-- 
2.7.4




More information about the wine-devel mailing list