[PATCH] gdiplus/tests: Don't fail if fonts are missing

Alex Henrie alexhenrie24 at gmail.com
Mon Oct 8 00:55:25 CDT 2018


On Thu, Oct 4, 2018 at 10:02 AM Vincent Povirk <vincent at codeweavers.com> wrote:
>
> I'm concerned that this will make the tests succeed with missing fonts
> on Windows, and the various name variables will be used uninitialized
> (which would've happened before, but only when the tests were
> failing). Maybe a todo_wine ok(0) and a return in the missing fonts
> case would solve that.
>
> It'd be nice to hear from the winetest maintainer about this case. In
> other cases, we've made the decision that the tests should fail if an
> API breaks because optional dependencies are missing. I don't know
> that we officially have a dependency on those fonts, but API's are
> breaking because they are missing.

That makes sense. It sounds like the right solution is to install
these fonts on our Debian testbot VMs.

-Alex



More information about the wine-devel mailing list