[PATCH] wined3d: Refactor blend factor from DWORD to wined3d_color

Henri Verbeet hverbeet at gmail.com
Tue Oct 9 09:31:24 CDT 2018


On Tue, 9 Oct 2018 at 02:18, Daniel Ansorregui <mailszeros at gmail.com> wrote:
>
> Signed-off-by: Daniel Ansorregui <mailszeros at gmail.com>
> ---
>  dlls/d3d11/device.c            | 15 ++++++++-------
>  dlls/d3d9/device.c             |  9 ++++++++-
>  dlls/wined3d/cs.c              | 28 ++++++++++++++++++++++++++++
>  dlls/wined3d/device.c          | 29 +++++++++++++++++++++++++++++
>  dlls/wined3d/state.c           | 11 ++++++-----
>  dlls/wined3d/stateblock.c      |  7 +++++--
>  dlls/wined3d/utils.c           |  3 ++-
>  dlls/wined3d/wined3d.spec      |  3 +++
>  dlls/wined3d/wined3d_private.h |  7 ++++++-
>  include/wine/wined3d.h         |  4 +++-
>  10 files changed, 98 insertions(+), 18 deletions(-)
>
Hi Daniel, thank you for the patch. Unfortunately the blend factor
should be part of the wined3d_blend_state object, so this patch would
be a step in the wrong direction. As I suspect you've already noticed,
the interaction with d3d9 in particular is the hard part of moving the
blend factor to the wined3d_blend_state object.



More information about the wine-devel mailing list