[PATCH 4/7] wined3d: Implement depth bias clamp.

Henri Verbeet hverbeet at gmail.com
Tue Oct 9 14:06:34 CDT 2018


On Tue, 9 Oct 2018 at 22:25, Matteo Bruni <matteo.mystral at gmail.com> wrote:
> On Mon, Oct 8, 2018 at 8:26 PM Henri Verbeet <hverbeet at codeweavers.com> wrote:
> > @@ -1254,7 +1255,9 @@ static enum wined3d_feature_level feature_level_from_caps(const struct wined3d_g
> >      shader_model = min(shader_model, max(shader_caps->hs_version, 4));
> >      shader_model = min(shader_model, max(shader_caps->ds_version, 4));
> >
> > -    if (gl_info->supported[WINED3D_GL_VERSION_3_2] && gl_info->supported[ARB_SAMPLER_OBJECTS])
> > +    if (gl_info->supported[WINED3D_GL_VERSION_3_2]
> > +            && gl_info->supported[ARB_POLYGON_OFFSET_CLAMP]
> > +            && gl_info->supported[ARB_SAMPLER_OBJECTS])
> >      {
> >          if (shader_model >= 5
> >                  && gl_info->supported[ARB_DRAW_INDIRECT]
>
> That kills d3d10 support on macOS. I know that it was a partial lie
> before anyway, but still...
>
I think Ken said we already don't report feature level 10 on MacOS. In
any case, lack of texture views already makes d3d10+ pretty hopeless
on MacOS, so I don't think anything of value would be lost in that
regard.

> Probably less of an issue, it also kills d3d10+ on older Mesa. Would
> you like / accept a patch adding a fallback to
> EXT_polygon_offset_clamp?
>
I had hoped we could avoid supporting the EXT extension, but it looks
like we may have to. So yeah, that's fine.



More information about the wine-devel mailing list