[PATCH] wined3d: Refactor blend factor from DWORD to wined3d_color

[DarkZeros]

Hi,

I think the best place is to put it under "wined3d_blend_state", not inside
the "wined3d_blend_state_desc".
And also reuse the CS of the blend state for the blend factor.
The only thing I am worried about is if we are setting the blend factor
each time the blend state is changed, even if they are unrelated.

Also this patch as it currently is, is breaking some d3d state tests (just
the test, the blending works fine), because they will have to be updated to
check the new state area.

I will do all the modifications soon and post another patch.

Cheers.

BR,
Daniel

El mar., 9 oct. 2018 a las 19:28, Stefan Dösinger (<
stefandoesinger at gmail.com>) escribió:

> Hi,
>
> Am 2018-10-09 um 16:31 schrieb Henri Verbeet:
> > Hi Daniel, thank you for the patch. Unfortunately the blend factor
> > should be part of the wined3d_blend_state object
> Are you sure this is the way to go? Creating a blend state object for
> every possible color combination seems highly inefficient.
>
> It could work if we add a setter to change the blend factor after
> creating a wined3d blend state object, but I don't see an advantage over
> Daniel's approach.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20181009/bde157d3/attachment.html>