[PATCH 1/2] shell32/iconcache: Prevent the imagelists from going out of sync by generating invalid icons from available icons

[Gabriel Ivăncescu]

On Tue, Oct 9, 2018 at 8:47 AM Nikolay Sivov <nsivov at codeweavers.com> wrote:
>
> Also, is it possible to have a test for this? Loading single icon size,
> and testing if the remaining sizes are created too?
>
>

Hi Nikolay,

I need some help with the tests, because I've no idea what executable
or file to use that exhibits this behavior, except for TurnItOn.exe
(linked in bug report).

Right now, I've got the tests working properly (meaning, it succeeds
on Windows XP, but fails on Wine without the patch), but they require
TurnItOn.exe, so I have something like:

SHGetFileInfoA("C:\\TurnItOn.exe", 0, &info, ...)

Then I check the ImageList_GetImageCount of SHIL_SMALL and SHIL_LARGE
and see if they differ (they do on Wine, not on Windows).

Which is obviously not acceptable for wine tests since the executable
is not bundled (but is required to exhibit the "out of sync" in the
system ImageLists). I'm not aware of any other executable or whatever
other file that exhibits this behavior.

What should I do?