[PATCH 1/2] wined3d: Add sync object after query buffer issue.

Henri Verbeet hverbeet at gmail.com
Sun Oct 14 09:45:29 CDT 2018


On Sun, 14 Oct 2018 at 01:09, Andrew Wesie <awesie at gmail.com> wrote:
> +    GL_EXTCALL(glMemoryBarrier(GL_CLIENT_MAPPED_BUFFER_BARRIER_BIT));
The ARB_buffer_storage spec is written against GL 4.3, but doesn't
seem to require it. I think that means you need to check for
ARB_SHADER_IMAGE_LOAD_STORE before using glMemoryBarrier().

> +    /* NVIDIA requires a sync object. */
I think I'd phrase that as "The ARB_buffer_storage spec requires …",
or just quote the relevant lines from the spec literally, and then add
a note that NVIDIA appears to enforce that, while Mesa doesn't.



More information about the wine-devel mailing list