[PATCH v3 2/2] shell32/tests: Test when IACList::Expand gets called and with what string

Huw Davies huw at codeweavers.com
Tue Oct 16 07:02:04 CDT 2018


On Tue, Oct 16, 2018 at 02:30:46PM +0300, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
> ---
> 
> I had to remove the #include of initguid.h because it gave a duplicate
> IID_ShellFolderView definition with shlobj.h, which is needed for IACList.
> 
>  dlls/shell32/tests/autocomplete.c | 114 +++++++++++++++++++++++++++++++++++---
>  1 file changed, 106 insertions(+), 8 deletions(-)
> 
> diff --git a/dlls/shell32/tests/autocomplete.c b/dlls/shell32/tests/autocomplete.c
> index e85e30c..66bd472 100644
> --- a/dlls/shell32/tests/autocomplete.c
> +++ b/dlls/shell32/tests/autocomplete.c
> @@ -25,8 +25,8 @@
>  #include "windows.h"
>  #include "shobjidl.h"
>  #include "shlguid.h"
> -#include "initguid.h"
>  #include "shldisp.h"
> +#include "shlobj.h"

I haven't looked at this patch properly yet, but note that while this
does appear to be correct here, initguid.h is not needed, had it been
you could have placed shlobj.h before initguid.h to avoid the
duplicate definition.

Huw.



More information about the wine-devel mailing list