[PATCH] winemenubuilder: Avoid unneeded lstrlenA() calls.

Francois Gouget fgouget at free.fr
Tue Oct 23 08:54:15 CDT 2018


Signed-off-by: Francois Gouget <fgouget at free.fr>
---

There is obviously no issue with NULL pointers here.

 programs/winemenubuilder/winemenubuilder.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c
index 9adfed63079..26710e9e926 100644
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -1468,13 +1468,13 @@ static BOOL write_desktop_entry(const char *unix_link, const char *location, con
             wine_get_config_dir(), path, args);
     fprintf(file, "Type=Application\n");
     fprintf(file, "StartupNotify=true\n");
-    if (descr && lstrlenA(descr))
+    if (descr && *descr)
         fprintf(file, "Comment=%s\n", descr);
-    if (workdir && lstrlenA(workdir))
+    if (workdir && *workdir)
         fprintf(file, "Path=%s\n", workdir);
-    if (icon && lstrlenA(icon))
+    if (icon && *icon)
         fprintf(file, "Icon=%s\n", icon);
-    if (wmclass && lstrlenA(wmclass))
+    if (wmclass && *wmclass)
         fprintf(file, "StartupWMClass=%s\n", wmclass);
 
     fclose(file);
-- 
2.19.1



More information about the wine-devel mailing list