shell32: Add bitmap resources for ids 133 and 134.

Huw Davies huw at codeweavers.com
Wed Oct 24 03:42:13 CDT 2018


Hi Dmitry,

On Wed, Oct 24, 2018 at 11:18:33AM +0300, Dmitry Timoshkov wrote:
> diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h
> index 16c92936ab..49fffeab5e 100644
> --- a/dlls/shell32/shresdef.h
> +++ b/dlls/shell32/shresdef.h
> @@ -427,6 +427,9 @@ FIXME: Need to add them, but for now just let them use the same: searching.avi
>  /* explorer toolbar icons
>   * FIXME: images are hacky and should be re-drawn; also dark and light bitmaps are same for now
>   */

I'd suggest moving the new defines before the above comment, since the comment
relates to the toolbar bitmaps.  Better still, perhaps the comment should just
go away?

> +#define IDB_UP_ARROW            133
> +#define IDB_DOWN_ARROW          134
> +
>  #define IDB_TB_LARGE_LIGHT      214
>  #define IDB_TB_LARGE_DARK       215
>  #define IDB_TB_SMALL_LIGHT      216
> -- 
> 2.17.1



More information about the wine-devel mailing list