shell32: Add bitmap resources for ids 133 and 134.

Dmitry Timoshkov dmitry at baikal.ru
Wed Oct 24 04:45:34 CDT 2018


Huw Davies <huw at codeweavers.com> wrote:

> > > > @@ -427,6 +427,9 @@ FIXME: Need to add them, but for now just let them use the same: searching.avi
> > > >  /* explorer toolbar icons
> > > >   * FIXME: images are hacky and should be re-drawn; also dark and light bitmaps are same for now
> > > >   */
> > > 
> > > I'd suggest moving the new defines before the above comment, since the comment
> > > relates to the toolbar bitmaps.  Better still, perhaps the comment should just
> > > go away?
> > 
> > The bimaps I've copied from user32 also need to be redrawn since they
> > should look a bit differently, so I'd prefer to leave both the comment
> > and the bitmaps order.
> 
> They're not 'explorer toolbar icons', right?

They look like a toolbar icon (an image list) although being a bitmap,
probably you are right about 'explorer', but personally I don't know
where they are supposed to be used. If you feel strongly about the bitmap
placement I'll resend with the suggested changes.

-- 
Dmitry.



More information about the wine-devel mailing list