[PATCH v3 3/6] shell32/autocomplete: Implement a cache and sort the enumerated strings for proper behavior

Huw Davies huw at codeweavers.com
Tue Oct 30 06:34:52 CDT 2018


On Tue, Oct 30, 2018 at 01:19:04PM +0200, Gabriel Ivăncescu wrote:
> BTW about the boolean, I just want to ask to be sure about this please:
> 
> The alternative would be to use a small goto as it was originally, all
> it does is basically break twice to outer scope (i.e. it's like "break
> 2" if C had such feature, or "break label" in some other languages). I
> suppose that's not acceptable though, right?

You already know the answer to the goto question.  The reason I was
querying about the need for the boolean, is that it's essentially
mirroring n == 0 so, at first look, it might be possible to rewrite
using that condition on the outer loop.

Huw.



More information about the wine-devel mailing list