[PATCH 07/17] shell32/autocomplete: Redesign the window proc to trigger on key presses, handle arbitrary sizes and avoid another buffer overflow

[Huw Davies]

On Thu, Sep 06, 2018 at 04:35:28PM +0300, Gabriel Ivăncescu wrote:
> On Thu, Sep 6, 2018 at 12:55 PM, Huw Davies <huw at codeweavers.com> wrote:
> >
> > Well the patch is too big, so start with moving the minor stuff to a
> > separate patch and let's see where we're at.  [Hint: any patch that
> > has "At the same time" in its commit message should probably be
> > split].
> >
> I was worried about that fact, but I'll end up rewriting some parts of
> the minor patch with the second one since most of it is intertwined. I
> hope that's ok. I'll try to split it up somehow.
> 
> That said I'll send the revised patches once I know what to do with
> 1/17  (and maybe 3/17 if you really want to take the 3 args out) since
> it's quite a large patchset and don't want to pollute the mailing list
> too much.

Limiting the patches to groups of around 7 or so would be good.
We'll get the first lot in, then we can work on the next batch -
I'm not going to review all 17 patches in one go.

Huw.