[PATCH 1/5] msi/tests: Add some tests for remote MSI summary info APIs.
Dmitry Timoshkov
dmitry at baikal.ru
Thu Sep 6 11:03:08 CDT 2018
Hans Leidekker <hans at codeweavers.com> wrote:
> On Thu, 2018-09-06 at 23:13 +0800, Dmitry Timoshkov wrote:
> > Is there any responsibility of a reviewer or a reasonable time frame
> > for a review, especially such a trivial patch set?
>
> You got a comment from Nikolay. I think he has a point, but I'm not
> clear on what it takes to handle SEH properly for these RPC calls.
Nikolay's comment is completely misleading and misguided.
> If it's not too much effort I would prefer doing that instead of
> spreading the current hack.
I just followed current pattern of handling NULL pointers. If there's
a consensus that it needs a different approach then all the APIs should
be reworked at once.
--
Dmitry.
More information about the wine-devel
mailing list