[PATCH v2 03/11] shell32/autocomplete: Handle heap_alloc failure and fix a vulnerability by avoiding the use of sprintf

Huw Davies huw at codeweavers.com
Mon Sep 10 02:44:53 CDT 2018


On Fri, Sep 07, 2018 at 01:33:48PM +0300, Gabriel Ivăncescu wrote:
> Oops, I rushed a bit with that change in and forgot to test because I
> thought it was trivial, I was scared to be too slow after replying to
> your points. Sorry about that.

Please don't rush.  I'd much rather you spend the time fixing and
reviewing the patches yourself as opposed to sending in patches which
I then have to correct.  Sending in version n+1 five minutes after
I've commented on version n isn't going to fill me with confidence.
It's not a race, Wine is over 25 years old, it can wait another day or
so!

Huw.



More information about the wine-devel mailing list