[PATCH 2/4] msxml3: Treat namespaces as floating attributes.
Dmitry Timoshkov
dmitry at baikal.ru
Tue Sep 11 00:05:21 CDT 2018
Daniel Lehman <dlehman25 at gmail.com> wrote:
> + if (curr) {
> + for (; attrIndex < index; attrIndex++) {
> + if (curr->next == NULL)
> + break;
> + else
> + curr = curr->next;
> + }
I understand that this is mostly a personal preference and there are other
places that use similar style, but wouldn't it be more clear without 'else'
or even this way:
if (curr) {
for (; attrIndex < index && curr->next != NULL; attrIndex++) {
curr = curr->next;
}
> + for (; attrIndex < index; attrIndex++) {
> + if (ns->next == NULL)
> return S_FALSE;
> else
> - curr = curr->next;
> + ns = ns->next;
> }
Same question about redundant 'else'.
--
Dmitry.
More information about the wine-devel
mailing list