[PATCH v4 07/10] shell32/autocomplete: Redesign the window proc to trigger on key presses instead of key release

[Huw Davies]

On Wed, Sep 12, 2018 at 01:42:26PM +0300, Gabriel Ivăncescu wrote:
> To be honest, I think it will be easier if I skip the no-op patch
> because this will allow me to allocate the hwndText in the helper
> function itself and skip passing it as argument, and encapsulate it
> there along with other stuff like the bools. Of course, most of the
> function will still be a cut & paste just like before (after the
> realloc part) so it will only seem artificially large but not that
> many changes (the control_char handling can be simplified by checking
> all of them for len of zero, which is better anyway). There's no issue
> with this, I hope? Or do I really have to make the no-op patch first?

I don't follow.  All of the uses of hwndText are inside the current
WM_KEYUP handler (at least after you resend the dynamic allocation
of hwndText patch), so what's the issue?

Remember, you're trying to make this as simple as possible for the
reviewers.  If there is a straight copy-n-paste patch into a helper
that makes life easy.  If not, then it's a large patch to review.

Huw.