[PATCH v5 2/7] shell32/autocomplete: Move the autocomplete processing to a separate function

[Gabriel Ivăncescu]

On Thu, Sep 13, 2018 at 1:34 PM, Huw Davies <huw at codeweavers.com> wrote:
>
> This wasn't exactly what I was expecting.  What I'd hoped to see was
> the entire WM_KEYUP handler moved to a helper function, not half of
> it.  [FWIW, renaming variable and re-formatting the code in the new
> helper is a good plan].
>
> After you do that, I then suggest pulling the code that deals with the
> displayall stuff into a sub-helper---this is most of the code that you
> have in autocomplete_text().
>
> Huw.
>

Oh okay I'll do that as well then. Can I also change the int len to
UINT in that block when doing it? (I know it doesn't matter in
practice, but this would limit x64 to 2GB due to a useless sign
extension to SIZE_T, which is what HeapAlloc uses -- it's mostly for
code purity than anything practical)