[PATCH] ole32: Release marshal data before removing apartment from list.
Sergio Gómez Del Real
sdelreal at codeweavers.com
Thu Sep 13 12:12:09 CDT 2018
I'm not sure how to add a test case here:
The issue is in apartment_release(), but specifically when the count
drops to 0 so that apartment gets destroyed. This function doesn't have
a means to communicate errors when releasing resources fail while
destroying apartment; it just returns a DWORD with the reference count.
As far as I can tell, there isn't any call to apartment_release() that
relies on the DWORD returned; we could return a special value here upon
failure releasing any resource, although I don't think that would be
useful in general (it would only be useful to the test case).
On 12/09/18 16:40, Marvin wrote:
> Thank you for your contribution to Wine!
>
> This is an automated notification to let you know that your patch has
> been reviewed and its status set to "Needs tests".
>
> This means that you need to write some test cases demonstrating that
> the patch is correct.
>
> If you do not understand the reason for this status, disagree with our
> assessment, or are simply not sure how to proceed next, please ask for
> clarification by replying to this email.
More information about the wine-devel
mailing list