[PATCH] urlmon/uri: Implement IsEqual for external implementations.
Nikolay Sivov
nsivov at codeweavers.com
Tue Sep 18 04:45:04 CDT 2018
On 09/17/2018 06:10 PM, Jacek Caban wrote:
> Hi Nikolay,
>
> On 09/17/2018 06:00 AM, Nikolay Sivov wrote:
>> Signed-off-by: Nikolay Sivov<nsivov at codeweavers.com>
>> ---
>> dlls/opcservices/tests/opcservices.c | 3 +--
>> dlls/urlmon/uri.c | 18 ++++++++++++++++--
>> 2 files changed, 17 insertions(+), 4 deletions(-)
>
>
> It would be interesting to have some urlmon tests for that. While what
> you do seems reasonable, a test in opcservices is not convincing. For
> all I know, native opcservices may call urlmon in a different way (or
> not at all). Please add a custom IUri implementation inside urlmon
> tests pass that to IsEqual.
>
Fair enough, I sent another version. Thanks for the review.
>
> Jacek
>
More information about the wine-devel
mailing list