[PATCH 3/4] msi/tests: Also test full range of properties for MsiSummaryInfoSetPropertyW.

Hans Leidekker hans at codeweavers.com
Wed Sep 19 03:15:45 CDT 2018


On Wed, 2018-09-19 at 13:27 +0800, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
> ---
>  dlls/msi/tests/custom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/dlls/msi/tests/custom.c b/dlls/msi/tests/custom.c
> index f06aee0675..c6e9f1eb52 100644
> --- a/dlls/msi/tests/custom.c
> +++ b/dlls/msi/tests/custom.c
> @@ -512,10 +512,10 @@ static void test_db(MSIHANDLE hinst)
>      {
>          r = MsiSummaryInfoSetPropertyA(suminfo, i, prop_type[i], 1252, &ft, "");
>          ok(hinst, r == ERROR_FUNCTION_FAILED, "%u: got %u\n", i, r);
> -    }
>  
> -    r = MsiSummaryInfoSetPropertyW(suminfo, PID_CODEPAGE, VT_I2, 1252, &ft, NULL);
> -    ok(hinst, r == ERROR_FUNCTION_FAILED, "got %u\n", r);
> +        r = MsiSummaryInfoSetPropertyW(suminfo, i, prop_type[i], 1252, &ft, NULL);
> +        ok(hinst, r == ERROR_FUNCTION_FAILED, "%u: got %u\n", i, r);
> +    }
>  
>      r = MsiCloseHandle(suminfo);
>      ok(hinst, !r, "got %u\n", r);

This is causing new test failures. The testbot fails recognize them
however, probably because they come from custom.c instead of the test
module that was invoked, install.c.




More information about the wine-devel mailing list