[PATCH 2/2] user32/listbox: Optimize SetCount partly

Huw Davies huw at codeweavers.com
Wed Sep 19 10:08:50 CDT 2018



> On 19 Sep 2018, at 15:35, Gabriel Ivăncescu <gabrielopcode at gmail.com> wrote:
> 
> On Wed, Sep 19, 2018 at 4:53 PM, Huw Davies <huw at codeweavers.com> wrote:
>> 
>> I think implementing LBS_NODATA should come before adding LB_SETCOUNT
>> code that will need to be changed again.  Also, adding a test to
>> show that LB_SETCOUNT fails if the style is LBS_OWNERDRAWFIXED, for
>> example, wouldn't hurt.
> BTW I think you meant OWNERDRAWVARIABLE right? LBS_OWNERDRAWFIXED
> should work (and is actually required) for LBS_NODATA (and thus,
> LB_SETCOUNT), or I'm missing something.

I just meant using the current test for LB_SETCOUNT and removing
the LBS_NODATA, which leaves LBS_OWNERDRAWFIXED on its own.

Huw.





More information about the wine-devel mailing list