[PATCH 3/4] msi/tests: Also test full range of properties for MsiSummaryInfoSetPropertyW.

Zebediah Figura z.figura12 at gmail.com
Wed Sep 19 10:09:22 CDT 2018


On 19/09/18 09:15, Francois Gouget wrote:
> On Wed, 19 Sep 2018, Hans Leidekker wrote:
> [...]
>> This is causing new test failures. The testbot fails recognize them
>> however, probably because they come from custom.c instead of the test
>> module that was invoked, install.c.
> I don't know how to improve handling of these cases.
> * The simplest for me would be if they issued 'install' errors instead 
>   but that would be confusing since the error does not come from 
>   install.c. So that's out.

Besides which it's used from multiple test units (action.c). Possibly it
shouldn't be, but I think the below proposed solution seems much better.

> 
> * Maybe add a new type of line to tie custom messages to the install 
>   test unit?
> 
>     0b40:install: Loading custom sub test unit.
> 
> 




More information about the wine-devel mailing list