[PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Sep 21 06:07:11 CDT 2018


On Fri, Sep 21, 2018 at 1:55 PM, Huw Davies <huw at codeweavers.com> wrote:
>
> Do you have an application that depends on this?  If not, we should
> leave it as it is.
>
> Huw.

Not that I'm aware of, but I thought matching Windows is a good idea
here. I should probably still send it directly to the control though
since it reduces needless overhead (especially due to GetPropW), but
then the code can be simplified a bit if I don't have to special-case
the WM_GETTEXT. The other hijack case needs to remain else I can't add
WM_SETTEXT to the messages handled later since it would result in a
recursive loop.

That said, It's a single extra call (get_edit_proc here), I don't
think it's so bad to keep it like this since it's still better
(behavior & overhead).



More information about the wine-devel mailing list