[PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

[Huw Davies]

On Fri, Sep 21, 2018 at 02:45:28PM +0300, Gabriel Ivăncescu wrote:
> On Fri, Sep 21, 2018 at 2:38 PM, Huw Davies <huw at codeweavers.com> wrote:
> >
> > Well firstly, I very much doubt the overhead is going to be relevant
> > for a user input driven auto-complete.
> >
> > We don't necessarily want to copy Windows' implementation exactly---
> > indeed if it's possible we try to avoid that.  As long as apps don't
> > notice the difference it's fine.
> >
> > Just make the changes that you need to add WM_SETTEXT.
> >
> > Huw.
> 
> I think we should avoid wineserver calls where possible, since it
> disrupts the wineserver also not just the specific application in
> question (in terms of overhead / blocking).
> 
> That said, if you don't want Windows behavior, I can get rid of
> get_edit_proc totally, and just replace SendMessage with
> CallWindowProc directly, which would still avoid wineserver calls
> here, and not add anything to the code than just replace the calls.
> 
> Well of course unless you really want to leave them as SendMessage but
> I think it's better to avoid wineserver calls if we can.

As I hinted at above, unless you can type very much faster than me
then I don't consider this much of an issue.

Huw.