[PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure

Gabriel Ivăncescu gabrielopcode at gmail.com
Fri Sep 21 09:39:35 CDT 2018


On Fri, Sep 21, 2018 at 5:33 PM, Alexandre Julliard <julliard at winehq.org> wrote:
>
> If it turns out that GetPropW is a bottleneck (very unlikely), it can be
> optimized in various ways. Please don't obfuscate the code in an attempt
> to make things faster where it doesn't matter.
>
> --
> Alexandre Julliard
> julliard at winehq.org

Well of course I wouldn't have messed with GetPropW, just replace
SendMessage with calling the edit control's procedure directly
(because ultimately that's what we ask it, for its data). I personally
don't think that's such an obfuscation or actually an obfuscation at
all, since it's crystal clear still to what the purpose is (and
personally, to me, makes more sense to ask the edit control directly).

However, I'll keep it as SendMessage then, unless you change your mind :-)

I was just clarifying my reasoning before in respect to where the
wineserver call was. A little bonus I guess is that it will also work
again with hijacking just like on Windows.



More information about the wine-devel mailing list