[PATCH v2 6/8] shell32/autocomplete: Re-arrange some fields for better packing

[Huw Davies]

On Tue, Sep 25, 2018 at 02:55:32PM +0300, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
> ---
> 
> Minor patch split from the next patch in the series from where it helps
> more. options field only really helps slightly with x86_64 to reduce
> padding bytes.
> 
>  dlls/shell32/autocomplete.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c
> index 05648c7..b3a6808 100644
> --- a/dlls/shell32/autocomplete.c
> +++ b/dlls/shell32/autocomplete.c
> @@ -67,8 +67,9 @@ typedef struct
>      IAutoComplete2 IAutoComplete2_iface;
>      IAutoCompleteDropDown IAutoCompleteDropDown_iface;
>      LONG ref;
> -    BOOL initialized;
> -    BOOL enabled;
> +    BOOLEAN initialized;
> +    BOOLEAN enabled;
> +    AUTOCOMPLETEOPTIONS options;
>      HWND hwndEdit;
>      HWND hwndListBox;
>      WNDPROC wpOrigEditProc;
> @@ -76,7 +77,6 @@ typedef struct
>      WCHAR *txtbackup;
>      WCHAR *quickComplete;
>      IEnumString *enumstr;
> -    AUTOCOMPLETEOPTIONS options;
>  } IAutoCompleteImpl;

I doubt all of this micro-optimization is really worth it (but please
let's not get into a debate about it).  If you're going to do this
stuff then using a bitfield for initialized and enabled is probably
what you want to do.

Huw.