[PATCH v3 4/6] shell32/autocomplete: Re-arrange some fields for better packing

Gabriel Ivăncescu gabrielopcode at gmail.com
Thu Sep 27 08:23:43 CDT 2018


On Thu, Sep 27, 2018 at 4:08 PM, Alexandre Julliard <julliard at winehq.org> wrote:
>
> The basic rule is that you don't make changes unless there's a
> reason. When things are simply a matter of taste and either way works
> fine, the existing code should be left alone.
>
> --
> Alexandre Julliard
> julliard at winehq.org

Yes but isn't a reason to possibly re-arrange it, when adding more
fields (patch 5/6)? Of course, it changes the overall layout, so it
won't just feel like it's built on top of each other, but rather like
it fits and belongs better together. i.e. like it was "designed like
this from the beginning" which is cleaner than trying to avoid to
change existing fields in my opinion.



More information about the wine-devel mailing list